kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Alexey Zaytsev <alexey.zaytsev@gmail.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: Don't automatically expose the TSC deadline timer in cpuid
Date: Mon, 26 Dec 2011 12:35:34 +0200	[thread overview]
Message-ID: <4EF84DF6.6090308@redhat.com> (raw)
In-Reply-To: <DE8DF0795D48FD4CA783C40EC8292335C034@SHSMSX101.ccr.corp.intel.com>

On 12/26/2011 10:42 AM, Liu, Jinsong wrote:
> >  }
> > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> > index df23dff..1171def 100644
> > --- a/arch/x86/kvm/x86.c
> > +++ b/arch/x86/kvm/x86.c
> > @@ -2089,6 +2089,9 @@ int kvm_dev_ioctl_check_extension(long ext)
> >  	case KVM_CAP_TSC_CONTROL:
> >  		r = kvm_has_tsc_control;
> >  		break;
> > +	case KVM_CAP_TSC_DEADLINE_TIMER:
> > +		r = boot_cpu_has(X86_FEATURE_TSC_DEADLINE_TIMER);
> > +		break;
>
> kvm tsc deadline timer is pure software emulated, not depend on host physically.

Yeah, I want to reconsider it in the 3.3 cycle.  I'm not so hot on
exposing non hardware features anymore, at least we want better
reporting to userspace.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2011-12-26 10:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-25 13:03 [PATCH] KVM: Don't automatically expose the TSC deadline timer in cpuid Avi Kivity
2011-12-25 18:39 ` Jan Kiszka
2011-12-26 11:14   ` Avi Kivity
2011-12-25 19:00 ` Sasha Levin
2011-12-25 19:47   ` Sasha Levin
2011-12-26  8:51     ` Liu, Jinsong
2011-12-26  0:44   ` Jan Kiszka
2011-12-26  8:42 ` Liu, Jinsong
2011-12-26 10:35   ` Avi Kivity [this message]
2011-12-26 10:43     ` Alexey Zaytsev
2011-12-26 10:45       ` Avi Kivity
2011-12-26 11:25         ` Alexey Zaytsev
2011-12-26 11:28           ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EF84DF6.6090308@redhat.com \
    --to=avi@redhat.com \
    --cc=alexey.zaytsev@gmail.com \
    --cc=jan.kiszka@siemens.com \
    --cc=jinsong.liu@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).