From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: Don't automatically expose the TSC deadline timer in cpuid Date: Mon, 26 Dec 2011 12:35:34 +0200 Message-ID: <4EF84DF6.6090308@redhat.com> References: <1324818200-15660-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , Alexey Zaytsev , Marcelo Tosatti , "kvm@vger.kernel.org" To: "Liu, Jinsong" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:2770 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754105Ab1LZKfl (ORCPT ); Mon, 26 Dec 2011 05:35:41 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 12/26/2011 10:42 AM, Liu, Jinsong wrote: > > } > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > > index df23dff..1171def 100644 > > --- a/arch/x86/kvm/x86.c > > +++ b/arch/x86/kvm/x86.c > > @@ -2089,6 +2089,9 @@ int kvm_dev_ioctl_check_extension(long ext) > > case KVM_CAP_TSC_CONTROL: > > r = kvm_has_tsc_control; > > break; > > + case KVM_CAP_TSC_DEADLINE_TIMER: > > + r = boot_cpu_has(X86_FEATURE_TSC_DEADLINE_TIMER); > > + break; > > kvm tsc deadline timer is pure software emulated, not depend on host physically. Yeah, I want to reconsider it in the 3.3 cycle. I'm not so hot on exposing non hardware features anymore, at least we want better reporting to userspace. -- error compiling committee.c: too many arguments to function