From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: Don't automatically expose the TSC deadline timer in cpuid Date: Mon, 26 Dec 2011 12:45:23 +0200 Message-ID: <4EF85043.4010607@redhat.com> References: <1324818200-15660-1-git-send-email-avi@redhat.com> <4EF84DF6.6090308@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: "Liu, Jinsong" , Jan Kiszka , Marcelo Tosatti , "kvm@vger.kernel.org" To: Alexey Zaytsev Return-path: Received: from mx1.redhat.com ([209.132.183.28]:14031 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754105Ab1LZKp3 (ORCPT ); Mon, 26 Dec 2011 05:45:29 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 12/26/2011 12:43 PM, Alexey Zaytsev wrote: > On Mon, Dec 26, 2011 at 12:35, Avi Kivity wrote: > > On 12/26/2011 10:42 AM, Liu, Jinsong wrote: > >> > } > >> > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > >> > index df23dff..1171def 100644 > >> > --- a/arch/x86/kvm/x86.c > >> > +++ b/arch/x86/kvm/x86.c > >> > @@ -2089,6 +2089,9 @@ int kvm_dev_ioctl_check_extension(long ext) > >> > case KVM_CAP_TSC_CONTROL: > >> > r = kvm_has_tsc_control; > >> > break; > >> > + case KVM_CAP_TSC_DEADLINE_TIMER: > >> > + r = boot_cpu_has(X86_FEATURE_TSC_DEADLINE_TIMER); > >> > + break; > >> > >> kvm tsc deadline timer is pure software emulated, not depend on host physically. > > > > Yeah, I want to reconsider it in the 3.3 cycle. I'm not so hot on > > exposing non hardware features anymore, at least we want better > > reporting to userspace. > > > > Just as a reminder, could you please revert the problematic commit > (a3e06bbe) for 3.2? I plan to post this as a fix. If you can, please test it: git://git.kernel.org/pub/scm/virt/kvm/kvm.git kvm-updates/3.2 -- error compiling committee.c: too many arguments to function