From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/3] KVM: MMU: Add missing large page accounting to drop_large_spte() Date: Mon, 26 Dec 2011 15:11:56 +0200 Message-ID: <4EF8729C.9000806@redhat.com> References: <20111129140147.c6b5a8f9.yoshikawa.takuya@oss.ntt.co.jp> <20111129140336.6e84d840.yoshikawa.takuya@oss.ntt.co.jp> <4EF01103.4060702@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org, takuya.yoshikawa@gmail.com To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59673 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755371Ab1LZNMC (ORCPT ); Mon, 26 Dec 2011 08:12:02 -0500 In-Reply-To: <4EF01103.4060702@oss.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 12/20/2011 06:37 AM, Takuya Yoshikawa wrote: > ping > > (2011/11/29 14:03), Takuya Yoshikawa wrote: >> Signed-off-by: Takuya Yoshikawa >> --- >> arch/x86/kvm/mmu.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c >> index 09da963..5e761ff 100644 >> --- a/arch/x86/kvm/mmu.c >> +++ b/arch/x86/kvm/mmu.c >> @@ -1803,6 +1803,7 @@ static void drop_large_spte(struct kvm_vcpu >> *vcpu, u64 *sptep) >> { >> if (is_large_pte(*sptep)) { >> drop_spte(vcpu->kvm, sptep); >> + --vcpu->kvm->stat.lpages; >> kvm_flush_remote_tlbs(vcpu->kvm); >> } >> } > > Is this fix wrong? > > I do not mind dropping other two cleanups in the patch set > if you do not like; of course I will update this if needed. > Sorry, missed it. It's not wrong, applied it and patch 1. -- error compiling committee.c: too many arguments to function