* kvm-kmod broken on Linux 2.6.32.y stable series [patch included] @ 2011-12-27 4:08 Richard Yao 2011-12-27 4:09 ` Richard Yao 0 siblings, 1 reply; 3+ messages in thread From: Richard Yao @ 2011-12-27 4:08 UTC (permalink / raw) To: kvm Commit 64c8f7b9a24b1de710ad8413da503d61ede6ae45 to Linux 2.6.32.y broke kvm-kmod. There are preprocessor directives in kvm-kmod that appear to be intended to remedy this, but there is a logical error in them. I have attached a patch that corrects that. I am not on the list, so please CC any replies to me. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: kvm-kmod broken on Linux 2.6.32.y stable series [patch included] 2011-12-27 4:08 kvm-kmod broken on Linux 2.6.32.y stable series [patch included] Richard Yao @ 2011-12-27 4:09 ` Richard Yao 2011-12-27 14:18 ` Jan Kiszka 0 siblings, 1 reply; 3+ messages in thread From: Richard Yao @ 2011-12-27 4:09 UTC (permalink / raw) To: kvm [-- Attachment #1: Type: text/plain, Size: 447 bytes --] I forgot to include the patch. Sorry about that. On Mon, Dec 26, 2011 at 11:08 PM, Richard Yao <ryao@cs.stonybrook.edu> wrote: > Commit 64c8f7b9a24b1de710ad8413da503d61ede6ae45 to Linux 2.6.32.y > broke kvm-kmod. There are preprocessor directives in kvm-kmod that > appear to be intended to remedy this, but there is a logical error in > them. I have attached a patch that corrects that. > > I am not on the list, so please CC any replies to me. [-- Attachment #2: kvm-kmod-3.1-fix-pvclock_scale_delta-preprocessor-definition.patch --] [-- Type: text/x-patch, Size: 578 bytes --] --- a/kvm-kmod-3.1/x86/external-module-compat.h 2011-12-26 22:50:44.703699133 -0500 +++ b/kvm-kmod-3.1/x86/external-module-compat.h 2011-12-26 22:55:52.990693699 -0500 @@ -1095,8 +1095,8 @@ #endif /* >= 2.6.36 */ -#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,37) || \ - (LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) && KERNEL_EXTRAVERSION < 40) +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,37) && \ + (LINUX_VERSION_CODE != KERNEL_VERSION(2,6,32) || KERNEL_EXTRAVERSION < 40) static inline u64 pvclock_scale_delta(u64 delta, u32 mul_frac, int shift) { u64 product; ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: kvm-kmod broken on Linux 2.6.32.y stable series [patch included] 2011-12-27 4:09 ` Richard Yao @ 2011-12-27 14:18 ` Jan Kiszka 0 siblings, 0 replies; 3+ messages in thread From: Jan Kiszka @ 2011-12-27 14:18 UTC (permalink / raw) To: Richard Yao; +Cc: kvm [-- Attachment #1: Type: text/plain, Size: 668 bytes --] On 2011-12-27 05:09, Richard Yao wrote: > I forgot to include the patch. Sorry about that. > > On Mon, Dec 26, 2011 at 11:08 PM, Richard Yao <ryao@cs.stonybrook.edu> wrote: >> Commit 64c8f7b9a24b1de710ad8413da503d61ede6ae45 to Linux 2.6.32.y >> broke kvm-kmod. There are preprocessor directives in kvm-kmod that >> appear to be intended to remedy this, but there is a logical error in >> them. I have attached a patch that corrects that. >> >> I am not on the list, so please CC any replies to me. Yeah logic is hard, and I mess it up way too often. :) Can you repost with proper patch subject/description and signed-off? Thanks in advance! Jan [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 262 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-12-27 14:18 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-12-27 4:08 kvm-kmod broken on Linux 2.6.32.y stable series [patch included] Richard Yao 2011-12-27 4:09 ` Richard Yao 2011-12-27 14:18 ` Jan Kiszka
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).