From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>,
kvm@vger.kernel.org
Subject: Re: [PATCH 3/4] KVM: Count the number of dirty pages for dirty logging
Date: Tue, 27 Dec 2011 17:18:28 +0200 [thread overview]
Message-ID: <4EF9E1C4.6000003@redhat.com> (raw)
In-Reply-To: <20111228001531.d93c090180bc3a28f01dd200@gmail.com>
On 12/27/2011 05:15 PM, Takuya Yoshikawa wrote:
> On Tue, 27 Dec 2011 17:06:47 +0200
> Avi Kivity <avi@redhat.com> wrote:
>
> > > There seems to be possible concurrent __set_bit()'s to the same word
> > > which will result in bit loss.
> > >
> > > I was thinking to change the kvm-unit-tests' dirty log test to write
> > > to two consecutive pages concurrently. Is this good for debugging this?
> >
> > Yes, it already tests some concurrency issues. Please do write the
> > test, we should do this a lot more often.
> >
>
> OK, I will write the test.
>
> If I can find a bit loss by that, I will send a fix patch: this is an
> important issue for my current work.
I'm pretty sure that the issue is real; if the test doesn't find an
error, it's probably not trying hard enough.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-12-27 15:18 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 9:20 [PATCH 0/4] KVM: Dirty logging optimization using rmap Takuya Yoshikawa
2011-11-14 9:21 ` [PATCH 1/4] KVM: MMU: Clean up BUG_ON() conditions in rmap_write_protect() Takuya Yoshikawa
2011-11-14 9:22 ` [PATCH 2/4] KVM: MMU: Split gfn_to_rmap() into two functions Takuya Yoshikawa
2011-11-14 9:23 ` [PATCH 3/4] KVM: Count the number of dirty pages for dirty logging Takuya Yoshikawa
2011-11-14 10:07 ` Avi Kivity
2011-11-14 10:24 ` Avi Kivity
2011-12-20 4:29 ` Takuya Yoshikawa
2011-12-23 11:14 ` Marcelo Tosatti
2011-12-24 2:52 ` Takuya Yoshikawa
2011-12-27 13:50 ` Marcelo Tosatti
2011-12-27 14:03 ` Avi Kivity
2011-12-27 15:03 ` Takuya Yoshikawa
2011-12-27 15:06 ` Avi Kivity
2011-12-27 15:15 ` Takuya Yoshikawa
2011-12-27 15:18 ` Avi Kivity [this message]
2011-11-14 9:24 ` [PATCH 4/4] KVM: Optimize dirty logging by rmap_write_protect() Takuya Yoshikawa
2011-11-14 10:22 ` Avi Kivity
2011-11-14 10:29 ` Takuya Yoshikawa
2011-11-14 10:25 ` [PATCH 0/4] KVM: Dirty logging optimization using rmap Avi Kivity
2011-11-14 10:56 ` Takuya Yoshikawa
2011-11-14 12:39 ` Avi Kivity
2011-11-16 4:28 ` Takuya Yoshikawa
2011-11-16 9:06 ` Avi Kivity
2011-11-29 10:01 ` Xiao Guangrong
2011-11-29 10:09 ` Xiao Guangrong
2011-11-29 10:35 ` Takuya Yoshikawa
2011-11-29 11:20 ` Avi Kivity
2011-11-29 11:56 ` Xiao Guangrong
2011-11-29 12:01 ` Avi Kivity
2011-11-29 14:03 ` Avi Kivity
2011-11-30 5:02 ` Takuya Yoshikawa
2011-11-30 5:15 ` Takuya Yoshikawa
2011-12-01 15:18 ` Avi Kivity
2011-12-03 4:37 ` Takuya Yoshikawa
2011-12-04 10:20 ` Avi Kivity
2011-11-30 7:10 ` Xiao Guangrong
2011-11-30 7:03 ` Xiao Guangrong
2011-12-01 15:11 ` Avi Kivity
2011-11-16 8:17 ` Takuya Yoshikawa
2011-11-17 9:28 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF9E1C4.6000003@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).