From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 00/11] Ucontrol patchset respin without storage keys Date: Wed, 04 Jan 2012 16:56:12 +0200 Message-ID: <4F04688C.1030205@redhat.com> References: <20120104092519.060746143@de.ibm.com> <4F046834.4030008@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tossati , Christian Borntraeger , Heiko Carstens , Martin Schwidefsky , Cornelia Huck , KVM , Joachim von Buttlar , Jens Freimann , agraf@suse.de To: Carsten Otte Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44634 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755689Ab2ADO4W (ORCPT ); Wed, 4 Jan 2012 09:56:22 -0500 In-Reply-To: <4F046834.4030008@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 01/04/2012 04:54 PM, Avi Kivity wrote: > On 01/04/2012 11:25 AM, Carsten Otte wrote: > > Hi Avi, > > > > after some more discussion about how to do storage keys proper, I could > > not come up with a sane and safe way of doing SSKE without either > > over or underindicating the change bit in corner cases (leads to > > corrupted guest memory or host kernel panic). > > The storage key operations are completely seperate from the rest of > > the ucontrol series: > > - ucontrol VMs can operate without them (handled by hardware) > > - regular VMs can make use of them too (needed for live migration) > > > > This respin only contains the non-controversial patches. I would > > kindly like to ask for inclusion, I will retry on storage keys as > > soon as I've got a solution. > > Everything looks good to me. I'll wait for a bit for more reviews (and > possibly Reviewed-by:s), and to see if my suggestion re patch 7 is any good. > btw, when I say "I'll wait a bit" I really mean "I'll forget everything about it", so feel free to remind me in a few days. -- error compiling committee.c: too many arguments to function