From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Subject: Re: [PATCH 08/50] KVM: PPC: Add support for explicit HIOR setting
Date: Wed, 4 Jan 2012 14:12:29 -0600
Message-ID: <4F04B2AD.9060404@freescale.com>
References: <1325639448-9494-1-git-send-email-agraf@suse.de> <1325639448-9494-9-git-send-email-agraf@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: <kvm-ppc@vger.kernel.org>, kvm list <kvm@vger.kernel.org>,
	Avi Kivity <avi@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <1325639448-9494-9-git-send-email-agraf@suse.de>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 01/03/2012 07:10 PM, Alexander Graf wrote:
> diff --git a/arch/powerpc/include/asm/kvm.h b/arch/powerpc/include/asm/kvm.h
> index 25964ee..fb3fddc 100644
> --- a/arch/powerpc/include/asm/kvm.h
> +++ b/arch/powerpc/include/asm/kvm.h
> @@ -327,4 +327,6 @@ struct kvm_book3e_206_tlb_params {
>  	__u32 reserved[8];
>  };
>  
> +#define KVM_ONE_REG_PPC_HIOR	KVM_ONE_REG_PPC | 0x100

Where does 0x100 come from?

There should probaly be some structure to the register space, with a
subarch field distinguishing between "common SPR", "book3s SPR", "book3e
SPR", along with others for non-SPR registers, KVM inventions, etc.

Can we shorten these to KVM_REG_PPC and KVM_REG_PPC_HIOR (especially if
we might use the same numbers for a future get/set many interface)?

-Scott