From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 13/50] KVM: PPC: booke: check for signals in kvmppc_vcpu_run Date: Sun, 08 Jan 2012 15:18:51 +0200 Message-ID: <4F0997BB.7010404@redhat.com> References: <1325639448-9494-1-git-send-email-agraf@suse.de> <1325639448-9494-14-git-send-email-agraf@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm-ppc@vger.kernel.org, kvm list , Marcelo Tosatti , Scott Wood To: Alexander Graf Return-path: Received: from mx1.redhat.com ([209.132.183.28]:62372 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753465Ab2AHNTB (ORCPT ); Sun, 8 Jan 2012 08:19:01 -0500 In-Reply-To: <1325639448-9494-14-git-send-email-agraf@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On 01/04/2012 03:10 AM, Alexander Graf wrote: > From: Scott Wood > > Currently we check prior to returning from a lightweight exit, > but not prior to initial entry. > > book3s already does a similar test. > > Signed-off-by: Scott Wood > Signed-off-by: Alexander Graf > --- > arch/powerpc/kvm/booke.c | 10 +++++++++- > 1 files changed, 9 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c > index b642200..9c78589 100644 > --- a/arch/powerpc/kvm/booke.c > +++ b/arch/powerpc/kvm/booke.c > @@ -322,11 +322,19 @@ int kvmppc_vcpu_run(struct kvm_run *kvm_run, struct kvm_vcpu *vcpu) > } > > local_irq_disable(); > + > + if (signal_pending(current)) { > + kvm_run->exit_reason = KVM_EXIT_INTR; > + ret = -EINTR; > + goto out; > + } > + > kvm_guest_enter(); > ret = __kvmppc_vcpu_run(kvm_run, vcpu); > kvm_guest_exit(); > - local_irq_enable(); > > In general a single check prior to entry is sufficient (well, in addition to the one in kvm_vcpu_block()). -- error compiling committee.c: too many arguments to function