From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 04/50] KVM: PPC: e500: MMU API
Date: Sun, 08 Jan 2012 16:55:30 +0200
Message-ID: <4F09AE62.3070709@redhat.com>
References: <1325639448-9494-1-git-send-email-agraf@suse.de> <1325639448-9494-5-git-send-email-agraf@suse.de> <4F099696.9070907@redhat.com> <15E4D81B-BF1E-43B8-AA36-CA4F9DFEB983@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: kvm-ppc@vger.kernel.org, kvm list <kvm@vger.kernel.org>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Scott Wood <scottwood@freescale.com>
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <15E4D81B-BF1E-43B8-AA36-CA4F9DFEB983@suse.de>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 01/08/2012 04:52 PM, Alexander Graf wrote:
> On 08.01.2012, at 14:13, Avi Kivity wrote:
>
> > On 01/04/2012 03:10 AM, Alexander Graf wrote:
> >> From: Scott Wood <scottwood@freescale.com>
> >> 
> >> This implements a shared-memory API for giving host userspace access to
> >> the guest's TLB.
> >> 
> >> 
> >> +4.59 KVM_DIRTY_TLB
> >> +
> >> +Capability: KVM_CAP_SW_TLB
> >> +Architectures: ppc
> >> +Type: vcpu ioctl
> >> +Parameters: struct kvm_dirty_tlb (in)
> >> +Returns: 0 on success, -1 on error
> >> +
> >> +struct kvm_dirty_tlb {
> >> +	__u64 bitmap;
> >> +	__u32 num_dirty;
> >> +};
> > 
> > Changes size with 32/64 bit userspace - is this an issue on this subarch?
>
> #include <stdio.h>
>
> int main(int argc, char **argv)
> {
>     struct x {
>         long long a;
>         int b;
>     } x;
>
>     printf("%d\n", sizeof(x));
>
>     return 0;
> }
>
> ---
>
> agraf@lychee:/dev/shm> gcc align.c -o align -m64
> agraf@lychee:/dev/shm> ./align
> 16
> agraf@lychee:/dev/shm> gcc align.c -o align -m32
> agraf@lychee:/dev/shm> ./align
> 16

Okay - I guess it's different to x86.  And I think we had this
conversation before...

-- 
error compiling committee.c: too many arguments to function