From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 06/50] KVM: PPC: e500: Don't hardcode PIR=0 Date: Sun, 08 Jan 2012 16:56:43 +0200 Message-ID: <4F09AEAB.6050204@redhat.com> References: <1325639448-9494-1-git-send-email-agraf@suse.de> <1325639448-9494-7-git-send-email-agraf@suse.de> <4F0996C9.8070209@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm-ppc@vger.kernel.org, kvm list , Marcelo Tosatti , Scott Wood To: Alexander Graf Return-path: In-Reply-To: Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 01/08/2012 04:53 PM, Alexander Graf wrote: > On 08.01.2012, at 14:14, Avi Kivity wrote: > > > On 01/04/2012 03:10 AM, Alexander Graf wrote: > >> From: Scott Wood > >> > >> The hardcoded behavior prevents proper SMP support. > >> > >> QEMU shall specify the vcpu's PIR as the vcpu id. > > > > s/QEMU/userspace/ > > This is a pull request, not a review request. You get it for free, when you ask me to pull. > While I'm open to suggestions on ABI corrections, I'd rather not go in and randomly change other people's commit descriptions :). If it's the only change, okay, otherwise please do change it. And keep it in mind for the future. -- error compiling committee.c: too many arguments to function