From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: [PATCH v2] qemu-kvm: Remove icache flush from cpu_physical_memory_rw Date: Thu, 19 Jan 2012 19:04:38 +0100 Message-ID: <4F185B36.1070103@siemens.com> References: <4F180EFC.80809@siemens.com> <20120119175409.GA18940@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , kvm To: Marcelo Tosatti Return-path: Received: from david.siemens.de ([192.35.17.14]:24433 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932657Ab2ASSEn (ORCPT ); Thu, 19 Jan 2012 13:04:43 -0500 In-Reply-To: <20120119175409.GA18940@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 2012-01-19 18:54, Marcelo Tosatti wrote: > On Thu, Jan 19, 2012 at 01:39:24PM +0100, Jan Kiszka wrote: >> This is at best a PPC topi but according to [1] even there unneeded. In >> any case, remove this diff to upstream, it should be handled there if >> actually needed. > > [1] ? > Oops. --------8<--------- This is at best a PPC topi but according to [1] even there unneeded. In any case, remove this diff to upstream, it should be handled there if actually needed. [1] http://thread.gmane.org/gmane.comp.emulators.qemu/119022/focus=119086 Signed-off-by: Jan Kiszka --- exec.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/exec.c b/exec.c index db837e2..0ca17fc 100644 --- a/exec.c +++ b/exec.c @@ -26,8 +26,6 @@ #include "qemu-common.h" #include "cpu.h" -#include "cache-utils.h" - #include "tcg.h" #include "hw/hw.h" #include "hw/qdev.h" @@ -3599,11 +3597,6 @@ void cpu_physical_memory_rw(target_phys_addr_t addr, uint8_t *buf, cpu_physical_memory_set_dirty_flags( addr1, (0xff & ~CODE_DIRTY_FLAG)); } - /* qemu doesn't execute guest code directly, but kvm does - therefore flush instruction caches */ - if (kvm_enabled()) - flush_icache_range((unsigned long)ptr, - ((unsigned long)ptr)+l); qemu_put_ram_ptr(ptr); } } else { -- 1.7.3.4