From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v8 18/18] kvm: Activate in-kernel irqchip support Date: Thu, 19 Jan 2012 19:54:24 +0100 Message-ID: <4F1866E0.7010900@web.de> References: <6a48ffaaa732b2142c1b5030178f2d4a0fa499fe.1326972302.git.jan.kiszka@siemens.com> <20120119180851.GA19099@amt.cnet> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigD0C4F3DC3B0553782114D215" Cc: Anthony Liguori , kvm@vger.kernel.org, "Michael S. Tsirkin" , qemu-devel , Blue Swirl , Avi Kivity To: Marcelo Tosatti Return-path: Received: from fmmailgate03.web.de ([217.72.192.234]:33141 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932454Ab2ASSyn (ORCPT ); Thu, 19 Jan 2012 13:54:43 -0500 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate03.web.de (Postfix) with ESMTP id 0A20E1AFEEDEF for ; Thu, 19 Jan 2012 19:54:42 +0100 (CET) In-Reply-To: <20120119180851.GA19099@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD0C4F3DC3B0553782114D215 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2012-01-19 19:08, Marcelo Tosatti wrote: > On Thu, Jan 19, 2012 at 12:25:10PM +0100, Jan Kiszka wrote: >> Make the basic in-kernel irqchip support selectable via >> -machine ...,kernel_irqchip=3Don. Leave it off by default until it can= >> fully replace user space models. >> >> Signed-off-by: Jan Kiszka >> --- >> qemu-config.c | 4 ++++ >> qemu-options.hx | 5 ++++- >> 2 files changed, 8 insertions(+), 1 deletions(-) >> >> diff --git a/qemu-config.c b/qemu-config.c >> index ecc88e8..b030205 100644 >> --- a/qemu-config.c >> +++ b/qemu-config.c >> @@ -531,6 +531,10 @@ static QemuOptsList qemu_machine_opts =3D { >> .name =3D "accel", >> .type =3D QEMU_OPT_STRING, >> .help =3D "accelerator list", >> + }, { >> + .name =3D "kernel_irqchip", >> + .type =3D QEMU_OPT_BOOL, >> + .help =3D "use KVM in-kernel irqchip", >> }, >> { /* End of list */ } >> }, >=20 >=20 > Pulled (and pushed), Thanks. Will refresh my back-merge patch for qemu-kvm now. > but you forgot to actually hook this option to kvm_irqchip_in_kernel? >=20 Nope, see kvm_irqchip_create, patch 13. You can also check by browsing the qtree (different device model names). Jan --------------enigD0C4F3DC3B0553782114D215 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8YZugACgkQitSsb3rl5xRYuwCdFIaJZ7naSFRRPIQgFj9ahV7a tEUAoOwRvAwYLlN1IlKOhJDEW6QJt2WV =3eiW -----END PGP SIGNATURE----- --------------enigD0C4F3DC3B0553782114D215--