public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm <kvm@vger.kernel.org>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: qemu-kvm upstreaming: Do we need -no-kvm-pit and -no-kvm-pit-reinjection semantics?
Date: Fri, 20 Jan 2012 11:22:27 +0100	[thread overview]
Message-ID: <4F194063.60307@siemens.com> (raw)
In-Reply-To: <20120120101441.GA31499@amt.cnet>

On 2012-01-20 11:14, Marcelo Tosatti wrote:
> On Thu, Jan 19, 2012 at 07:01:44PM +0100, Jan Kiszka wrote:
>> On 2012-01-19 18:53, Marcelo Tosatti wrote:
>>>> What problems does it cause, and in which scenarios? Can't they be
>>>> fixed?
>>>
>>> If the guest compensates for lost ticks, and KVM reinjects them, guest
>>> time advances faster then it should, to the extent where NTP fails to
>>> correct it. This is the case with RHEL4.
>>>
>>> But for example v2.4 kernel (or Windows with non-acpi HAL) do not
>>> compensate. In that case you want KVM to reinject.
>>>
>>> I don't know of any other way to fix this.
>>
>> OK, i see. The old unsolved problem of guessing what is being executed.
>>
>> Then the next question is how and where to control this. Conceptually,
>> there should rather be a global switch say "compensate for lost ticks of
>> periodic timers: yes/no" - instead of a per-timer knob. Didn't we
>> discussed something like this before?
> 
> I don't see the advantage of a global control versus per device
> control (in fact it lowers flexibility).

Usability. Users should not have to care about individual tick-based
clocks. They care about "my OS requires lost ticks compensation, yes or no".

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

  reply	other threads:[~2012-01-20 10:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-19  8:33 qemu-kvm upstreaming: Do we need -no-kvm-pit and -no-kvm-pit-reinjection semantics? Jan Kiszka
2012-01-19 17:25 ` Marcelo Tosatti
2012-01-19 17:38   ` Jan Kiszka
2012-01-19 17:53     ` Marcelo Tosatti
2012-01-19 18:01       ` Jan Kiszka
2012-01-20 10:14         ` Marcelo Tosatti
2012-01-20 10:22           ` Jan Kiszka [this message]
2012-01-20 10:25             ` [Qemu-devel] " Daniel P. Berrange
2012-01-20 11:13               ` Jan Kiszka
2012-01-20 11:45                 ` Daniel P. Berrange
2012-01-20 12:00                   ` Jan Kiszka
2012-01-20 12:42                     ` Daniel P. Berrange
2012-01-20 12:51                       ` Jan Kiszka
2012-01-20 12:54                         ` Daniel P. Berrange
2012-01-20 13:02                           ` Jan Kiszka
2012-01-20 13:06                             ` Daniel P. Berrange
2012-01-20 10:39             ` Jamie Lokier
2012-01-20 11:13               ` [Qemu-devel] " Jan Kiszka
2012-01-20 12:00                 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F194063.60307@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox