From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] KVM: Factor out kvm_vcpu_kick to arch-generic code Date: Fri, 20 Jan 2012 17:43:28 +0100 Message-ID: <4F1999B0.6020208@siemens.com> References: <20120120032241.24615.65895.stgit@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marc.Zyngier@arm.com, mtosatti@redhat.com, agraf@suse.de, kvm-ppc@vger.kernel.org, avi@redhat.com, android-virt@lists.cs.columbia.edu, tech@virtualopensystems.com To: Christoffer Dall Return-path: Received: from thoth.sbs.de ([192.35.17.2]:22252 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753773Ab2ATQnq (ORCPT ); Fri, 20 Jan 2012 11:43:46 -0500 In-Reply-To: <20120120032241.24615.65895.stgit@localhost> Sender: kvm-owner@vger.kernel.org List-ID: On 2012-01-20 04:22, Christoffer Dall wrote: > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index d9cfb78..cd30b68 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -153,6 +153,7 @@ void vcpu_load(struct kvm_vcpu *vcpu) > cpu = get_cpu(); > preempt_notifier_register(&vcpu->preempt_notifier); > kvm_arch_vcpu_load(vcpu, cpu); > + vcpu->cpu = cpu; That means setting it in the various kvm_arch_vcpu_load handlers becomes redundant and should be cleaned up. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux