From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH v2] qemu-kvm: Remove icache flush from cpu_physical_memory_rw Date: Mon, 23 Jan 2012 18:26:06 -0600 Message-ID: <4F1DFA9E.2010602@freescale.com> References: <4F180EFC.80809@siemens.com> <20120119175409.GA18940@amt.cnet> <4F185B36.1070103@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Avi Kivity , kvm , Alexander Graf To: Jan Kiszka Return-path: Received: from ch1ehsobe003.messaging.microsoft.com ([216.32.181.183]:50675 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754236Ab2AXA0K (ORCPT ); Mon, 23 Jan 2012 19:26:10 -0500 In-Reply-To: <4F185B36.1070103@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 01/19/2012 12:04 PM, Jan Kiszka wrote: > On 2012-01-19 18:54, Marcelo Tosatti wrote: >> On Thu, Jan 19, 2012 at 01:39:24PM +0100, Jan Kiszka wrote: >>> This is at best a PPC topi but according to [1] even there unneeded. In >>> any case, remove this diff to upstream, it should be handled there if >>> actually needed. >> >> [1] ? >> > > Oops. > > --------8<--------- > > This is at best a PPC topi but according to [1] even there unneeded. In > any case, remove this diff to upstream, it should be handled there if > actually needed. > > [1] http://thread.gmane.org/gmane.comp.emulators.qemu/119022/focus=119086 That says that it's unneeded on (some?) IBM Power systems. We need it on Freescale chips. I submitted an upstream-QEMU patch to do this flush (referenced in that thread, still not applied) because I was seeing cache problems when loading images. -Scott