From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/4] KVM: Decouple rmap_pde from lpage_info write_count Date: Tue, 24 Jan 2012 13:24:56 +0200 Message-ID: <4F1E9508.6010205@redhat.com> References: <20120123194204.268410c4.yoshikawa.takuya@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org To: Takuya Yoshikawa Return-path: In-Reply-To: <20120123194204.268410c4.yoshikawa.takuya@oss.ntt.co.jp> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 01/23/2012 12:42 PM, Takuya Yoshikawa wrote: > The last one is an RFC patch: > > I think it is better to refactor the rmap things, if needed, before > other architectures than x86 starts large pages support. > Not commenting about the meat of the patches (not sufficiently recovered yet), but other architectures may not want the write_count stuff at all, or even kvm_memory_slot::rmap. It may make sense to move those members into a new kvm_memory_slot::arch arch-specific substructure. -- error compiling committee.c: too many arguments to function