From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v2] qemu-kvm: Remove icache flush from cpu_physical_memory_rw Date: Tue, 24 Jan 2012 12:38:04 +0100 Message-ID: <4F1E981C.5040803@siemens.com> References: <4F180EFC.80809@siemens.com> <20120119175409.GA18940@amt.cnet> <4F185B36.1070103@siemens.com> <4F1DFA9E.2010602@freescale.com> <4F1E7266.5000800@siemens.com> <4F1E975A.10600@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Scott Wood , Marcelo Tosatti , kvm , Alexander Graf To: Avi Kivity Return-path: Received: from thoth.sbs.de ([192.35.17.2]:27070 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221Ab2AXLiN (ORCPT ); Tue, 24 Jan 2012 06:38:13 -0500 In-Reply-To: <4F1E975A.10600@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2012-01-24 12:34, Avi Kivity wrote: > On 01/24/2012 10:57 AM, Jan Kiszka wrote: >>> That says that it's unneeded on (some?) IBM Power systems. We need it >>> on Freescale chips. I submitted an upstream-QEMU patch to do this flush >>> (referenced in that thread, still not applied) because I was seeing >>> cache problems when loading images. >> >> Then you probably want to limit your patch's effect to that particular >> set of chips and repost it to qemu-devel. In any case, it's not a >> qemu-kvm topic as we are x86-only for quite a while. >> > > IIRC introduced for ia64. But isn't the correct action adding it to > qemu.git instead of removing it completely? Adding something to qemu.git, yes, keeping it here without knowing the final code, no. This is just another unused variation from upstream. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux