From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= Subject: Re: [Qemu-devel] [PATCH v2 3/4] uq/master: Add CPU eject handling for acpi_piix4 Date: Tue, 24 Jan 2012 13:52:44 +0100 Message-ID: <4F1EA99C.702@suse.de> References: <1327399808-31081-1-git-send-email-vasilis.liaskovitis@profitbricks.com> <1327399808-31081-4-git-send-email-vasilis.liaskovitis@profitbricks.com> <4F1E87D9.6000008@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Vasilis Liaskovitis , "mtosatti@redhat.com" , "kvm@vger.kernel.org" , "gleb@redhat.com" , "seabios@seabios.org" , "qemu-devel@nongnu.org" , "kernelfans@gmail.com" , "kevin@koconnor.net" , "avi@redhat.com" To: Jan Kiszka Return-path: Received: from cantor2.suse.de ([195.135.220.15]:49248 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754868Ab2AXMyy (ORCPT ); Tue, 24 Jan 2012 07:54:54 -0500 In-Reply-To: <4F1E87D9.6000008@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: Am 24.01.2012 11:28, schrieb Jan Kiszka: > On 2012-01-24 11:10, Vasilis Liaskovitis wrote: >> diff --git a/hw/pc_piix.c b/hw/pc_piix.c >> index ac251c6..6d61567 100644 >> --- a/hw/pc_piix.c >> +++ b/hw/pc_piix.c >> @@ -380,6 +380,14 @@ static QEMUMachine pc_machine_v1_1 =3D { >> .desc =3D "Standard PC", >> .init =3D pc_init_pci, >> .max_cpus =3D 255, >> + .compat_props =3D (GlobalProperty[]) { >> + { >> + .driver =3D "PIIX4_PM", >> + .property =3D "cpu_acpi_eject", >> + .value =3D stringify(1), >=20 > Such things are usually handled the other way around: define > no_cpu_acpi_eject and set it in all legacy machines. Either way reminds me that qdev bool support never got merged. I'll dig it out and rebase. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg