From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/4] uq/master: Add CPU eject
 handling for acpi_piix4
Date: Tue, 24 Jan 2012 13:57:52 +0100
Message-ID: <4F1EAAD0.1010705@siemens.com>
References: <1327399808-31081-1-git-send-email-vasilis.liaskovitis@profitbricks.com>
	<1327399808-31081-4-git-send-email-vasilis.liaskovitis@profitbricks.com>
	<4F1E87D9.6000008@siemens.com> <4F1EA99C.702@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: "seabios@seabios.org" <seabios@seabios.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"kernelfans@gmail.com" <kernelfans@gmail.com>,
	"avi@redhat.com" <avi@redhat.com>
To: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Return-path: <seabios-bounces@seabios.org>
In-Reply-To: <4F1EA99C.702@suse.de>
List-Unsubscribe: <http://www.seabios.org/mailman/options/seabios>,
	<mailto:seabios-request@seabios.org?subject=unsubscribe>
List-Archive: <http://www.seabios.org/pipermail/seabios>
List-Post: <mailto:seabios@seabios.org>
List-Help: <mailto:seabios-request@seabios.org?subject=help>
List-Subscribe: <http://www.seabios.org/mailman/listinfo/seabios>,
	<mailto:seabios-request@seabios.org?subject=subscribe>
Errors-To: seabios-bounces@seabios.org
Sender: seabios-bounces@seabios.org
List-Id: kvm.vger.kernel.org

On 2012-01-24 13:52, Andreas F=E4rber wrote:
> Am 24.01.2012 11:28, schrieb Jan Kiszka:
>> On 2012-01-24 11:10, Vasilis Liaskovitis wrote:
>>> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
>>> index ac251c6..6d61567 100644
>>> --- a/hw/pc_piix.c
>>> +++ b/hw/pc_piix.c
>>> @@ -380,6 +380,14 @@ static QEMUMachine pc_machine_v1_1 =3D {
>>>      .desc =3D "Standard PC",
>>>      .init =3D pc_init_pci,
>>>      .max_cpus =3D 255,
>>> +    .compat_props =3D (GlobalProperty[]) {
>>> +        {
>>> +            .driver   =3D "PIIX4_PM",
>>> +            .property =3D "cpu_acpi_eject",
>>> +            .value    =3D stringify(1),
>>
>> Such things are usually handled the other way around: define
>> no_cpu_acpi_eject and set it in all legacy machines.
> =

> Either way reminds me that qdev bool support never got merged. I'll dig
> it out and rebase.

Perfect! I really hate to model bool via bit.

Jan

-- =

Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux