From: Jan Kiszka <jan.kiszka@siemens.com>
To: Avi Kivity <avi@redhat.com>
Cc: Scott Wood <scottwood@freescale.com>,
Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>,
Alexander Graf <agraf@suse.de>
Subject: Re: [PATCH v2] qemu-kvm: Remove icache flush from cpu_physical_memory_rw
Date: Tue, 24 Jan 2012 14:12:25 +0100 [thread overview]
Message-ID: <4F1EAE39.2040801@siemens.com> (raw)
In-Reply-To: <4F1EADA0.2000205@redhat.com>
On 2012-01-24 14:09, Avi Kivity wrote:
> On 01/24/2012 01:38 PM, Jan Kiszka wrote:
>>>
>>> IIRC introduced for ia64. But isn't the correct action adding it to
>>> qemu.git instead of removing it completely?
>>
>> Adding something to qemu.git, yes, keeping it here without knowing the
>> final code, no.
>
> This is called introducing a regression.
There is nothing to regress here.
>
>> This is just another unused variation from upstream.
>
> It's wasn't unused when ia64 was alive. Just removing it means more
> work later to rediscover it (and anyway ppc needs it).
ppc is not used with qemu-kvm, it's used with qemu upstream. qemu-kvm is
a x86-only show today.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2012-01-24 13:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 12:39 [PATCH] qemu-kvm: Remove icache flush from cpu_physical_memory_rw Jan Kiszka
2012-01-19 17:54 ` Marcelo Tosatti
2012-01-19 18:04 ` [PATCH v2] " Jan Kiszka
2012-01-20 10:25 ` Marcelo Tosatti
2012-01-24 0:26 ` Scott Wood
2012-01-24 8:57 ` Jan Kiszka
2012-01-24 11:34 ` Avi Kivity
2012-01-24 11:38 ` Jan Kiszka
2012-01-24 13:09 ` Avi Kivity
2012-01-24 13:12 ` Jan Kiszka [this message]
2012-01-24 13:26 ` Avi Kivity
2012-01-24 13:29 ` Jan Kiszka
2012-01-25 14:23 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1EAE39.2040801@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox