From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v2] qemu-kvm: Remove icache flush from cpu_physical_memory_rw Date: Tue, 24 Jan 2012 14:12:25 +0100 Message-ID: <4F1EAE39.2040801@siemens.com> References: <4F180EFC.80809@siemens.com> <20120119175409.GA18940@amt.cnet> <4F185B36.1070103@siemens.com> <4F1DFA9E.2010602@freescale.com> <4F1E7266.5000800@siemens.com> <4F1E975A.10600@redhat.com> <4F1E981C.5040803@siemens.com> <4F1EADA0.2000205@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Scott Wood , Marcelo Tosatti , kvm , Alexander Graf To: Avi Kivity Return-path: Received: from david.siemens.de ([192.35.17.14]:17995 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752923Ab2AXNMf (ORCPT ); Tue, 24 Jan 2012 08:12:35 -0500 In-Reply-To: <4F1EADA0.2000205@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2012-01-24 14:09, Avi Kivity wrote: > On 01/24/2012 01:38 PM, Jan Kiszka wrote: >>> >>> IIRC introduced for ia64. But isn't the correct action adding it to >>> qemu.git instead of removing it completely? >> >> Adding something to qemu.git, yes, keeping it here without knowing the >> final code, no. > > This is called introducing a regression. There is nothing to regress here. > >> This is just another unused variation from upstream. > > It's wasn't unused when ia64 was alive. Just removing it means more > work later to rediscover it (and anyway ppc needs it). ppc is not used with qemu-kvm, it's used with qemu upstream. qemu-kvm is a x86-only show today. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux