Re: [PATCH v2] qemu-kvm: Remove icache flush from cpu_physical_memory_rw

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2012-01-24 14:26, Avi Kivity wrote:
> On 01/24/2012 03:12 PM, Jan Kiszka wrote:
>> On 2012-01-24 14:09, Avi Kivity wrote:
>>> On 01/24/2012 01:38 PM, Jan Kiszka wrote:
>>>>>
>>>>> IIRC introduced for ia64.  But isn't the correct action adding it to
>>>>> qemu.git instead of removing it completely?
>>>>
>>>> Adding something to qemu.git, yes, keeping it here without knowing the
>>>> final code, no. 
>>>
>>> This is called introducing a regression.
>>
>> There is nothing to regress here.
>>
>>>
>>>> This is just another unused variation from upstream.
>>>
>>> It's wasn't unused when ia64 was alive.  Just removing it means more
>>> work later to rediscover it (and anyway ppc needs it).
>>
>> ppc is not used with qemu-kvm, it's used with qemu upstream. qemu-kvm is
>> a x86-only show today.
>>
> 
> Does qemu.git have this hook for ppc?

It was introduced for ia64. That's buried now. Then ppc came along and
may have needed it as well. But ppc became broken in qemu-kvm a long
time ago, may work today again (due to thread model unifications), but
is definitely out of focus for this tree. So these bits are misplaced
here IMHO.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux