From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH v2] qemu-kvm: Remove icache flush from cpu_physical_memory_rw Date: Wed, 25 Jan 2012 15:23:01 +0100 Message-ID: <4F201045.5020202@suse.de> References: <4F180EFC.80809@siemens.com> <20120119175409.GA18940@amt.cnet> <4F185B36.1070103@siemens.com> <4F1DFA9E.2010602@freescale.com> <4F1E7266.5000800@siemens.com> <4F1E975A.10600@redhat.com> <4F1E981C.5040803@siemens.com> <4F1EADA0.2000205@redhat.com> <4F1EAE39.2040801@siemens.com> <4F1EB192.8030806@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , Scott Wood , Marcelo Tosatti , kvm To: Avi Kivity Return-path: Received: from cantor2.suse.de ([195.135.220.15]:37075 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750833Ab2AYOXD (ORCPT ); Wed, 25 Jan 2012 09:23:03 -0500 In-Reply-To: <4F1EB192.8030806@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 01/24/2012 02:26 PM, Avi Kivity wrote: > On 01/24/2012 03:12 PM, Jan Kiszka wrote: >> On 2012-01-24 14:09, Avi Kivity wrote: >>> On 01/24/2012 01:38 PM, Jan Kiszka wrote: >>>>> IIRC introduced for ia64. But isn't the correct action adding it to >>>>> qemu.git instead of removing it completely? >>>> Adding something to qemu.git, yes, keeping it here without knowing the >>>> final code, no. >>> This is called introducing a regression. >> There is nothing to regress here. >> >>>> This is just another unused variation from upstream. >>> It's wasn't unused when ia64 was alive. Just removing it means more >>> work later to rediscover it (and anyway ppc needs it). >> ppc is not used with qemu-kvm, it's used with qemu upstream. qemu-kvm is >> a x86-only show today. >> > Does qemu.git have this hook for ppc? See Scott's patch: http://patchwork.ozlabs.org/patch/90403/ Alex