From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Wolf Subject: Re: [PATCH v2 0/3] Fix task switches into/out of VM86 Date: Mon, 30 Jan 2012 09:48:33 +0100 Message-ID: <4F265961.3070501@redhat.com> References: <1327692216-20450-1-git-send-email-kwolf@redhat.com> <20120127195239.GB2938@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, joerg.roedel@amd.com, yoshikawa.takuya@oss.ntt.co.jp, avi@redhat.com, mtosatti@redhat.com To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:5188 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752725Ab2A3IpM (ORCPT ); Mon, 30 Jan 2012 03:45:12 -0500 In-Reply-To: <20120127195239.GB2938@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Am 27.01.2012 20:52, schrieb Gleb Natapov: > On Fri, Jan 27, 2012 at 08:23:33PM +0100, Kevin Wolf wrote: >> I believe this should work with both VMX and SVM now. Gleb, J=C3=B6r= g, can one of >> you test this with SVM? I did some testing on my buggy processor and= it looks >> as good as it gets, but it would be better if you could confirm. >> > You forgot to set cpl to 3 in vmcb in svm_set_rflags() when vm86 is e= nabled, no? SVM updates the CPL when the segment selector for CS is loaded. From a svm.c POV, segment selectors are updated immediately after set_rflags, so it wouldn't really make a difference to do it twice. Kevin