From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/9] pci-assign: Optionally enable 64bit BARs in guest Date: Tue, 31 Jan 2012 14:40:58 +0200 Message-ID: <4F27E15A.1090800@redhat.com> References: <20120128142104.25681.93072.stgit@bling.home> <20120128142139.25681.19080.stgit@bling.home> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, jan.kiszka@siemens.com, shashidhar.patil@gmail.com To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:31177 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752256Ab2AaMlE (ORCPT ); Tue, 31 Jan 2012 07:41:04 -0500 In-Reply-To: <20120128142139.25681.19080.stgit@bling.home> Sender: kvm-owner@vger.kernel.org List-ID: On 01/28/2012 04:21 PM, Alex Williamson wrote: > To date we've only exposed BARs as 32bit even if the device > physically supports 64bit BARs. Enable 64bit BARs to be > exposed as such in the guest, which may free up MMIO below > 4G should the guest choose to use it. > > This adds a new mem64= option to pci-assign, with the > default being off for testing and enablement. The goal > is to eventually make this enabled by default. > Seems fine, but do we really need the option? If it doesn't work we should treat it as an ordinary but and fix it. -- error compiling committee.c: too many arguments to function