From: Jan Kiszka <jan.kiszka@siemens.com>
To: Avi Kivity <avi@redhat.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"shashidhar.patil@gmail.com" <shashidhar.patil@gmail.com>
Subject: Re: [PATCH 0/9] pci-assign: 64bit MMIO + better MSI-X table support
Date: Tue, 31 Jan 2012 13:56:15 +0100 [thread overview]
Message-ID: <4F27E4EF.5000204@siemens.com> (raw)
In-Reply-To: <4F27E412.9070103@redhat.com>
On 2012-01-31 13:52, Avi Kivity wrote:
> On 01/30/2012 03:44 PM, Alex Williamson wrote:
>> On Mon, 2012-01-30 at 11:11 +0100, Jan Kiszka wrote:
>>> On 2012-01-28 15:21, Alex Williamson wrote:
>>>> Patch 1 & 2 here are independent of the rest, but I include them
>>>> here to avoid conflicts. The first patch enables exposing MMIO
>>>> BARs as their native width to the guest. I added a config option
>>>> for this with the default to use the existing behavior as I
>>>> suspect we may have some latent issues there. Patch 2 is just
>>>> some trivial debug build warning fixes.
>>>>
>>>> The rest of the patches work on improving MSI-X table support.
>>>> Particularly, vectors can now be updated by the guest after
>>>> MSI-X is enabled to support things like irqbalance for SMP
>>>> affinity tuning. We also now update MSI-X configuration as
>>>> new vectors are unmasked, which enables assignment of MSI-X
>>>> devices on FreeBSD. I was able to assign and use an 82576
>>>> (PF & VF) on a FreeBSD 9.0 guest with this series. Hopefully
>>>> Shashidhar can report whether this improves the behavior he
>>>> as seeing with an 82599.
>>>>
>>>> I wasn't able to get masking to work reliably, so I left that
>>>> as is for now. Perhaps someone has suggestions on getting that
>>>> to work. Thanks,
>>>
>>> Unless it's urging, let's focus on getting this implemented via the
>>> MSI/MSI-X core, not widely duplicated in device-assignment.
>>
>> I disagree. This isn't making the code duplication worse and it solves
>> at least two use cases that are currently broken. This won't make it
>> any more difficult to eventually move to msix.c, if it does, the core
>> needs more work. Thanks,
>>
>
> I agree (with Alex), but maybe I missed something? Patch 9 does call
> kvm directly instead of going through msi services, but I don't think
> this should hold the patches.
If this solves the issues, ok. That all needs quite some refactoring
anyway (including the kvm core services).
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2012-01-31 12:56 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-28 14:21 [PATCH 0/9] pci-assign: 64bit MMIO + better MSI-X table support Alex Williamson
2012-01-28 14:21 ` [PATCH 1/9] pci-assign: Optionally enable 64bit BARs in guest Alex Williamson
2012-01-31 12:40 ` Avi Kivity
2012-01-31 12:45 ` Jan Kiszka
2012-01-31 12:51 ` Avi Kivity
2012-01-31 12:57 ` Jan Kiszka
2012-01-31 13:10 ` Avi Kivity
2012-01-31 13:21 ` Jan Kiszka
2012-01-31 13:33 ` Avi Kivity
2012-01-31 21:08 ` Alex Williamson
2012-01-31 21:14 ` Michael S. Tsirkin
2012-02-01 9:03 ` Avi Kivity
2012-02-01 10:03 ` Michael S. Tsirkin
2012-02-01 13:55 ` Alex Williamson
2012-02-01 15:18 ` Michael S. Tsirkin
2012-02-01 15:24 ` Alex Williamson
2012-01-28 14:21 ` [PATCH 2/9] pci-assign: Fix warnings with DEBUG enabled Alex Williamson
2012-01-28 14:21 ` [PATCH 3/9] pci-assign: Update MSI-X MMIO to Memory API Alex Williamson
2012-01-31 12:45 ` Avi Kivity
2012-01-31 21:13 ` Alex Williamson
2012-02-01 4:22 ` Alex Williamson
2012-02-01 9:04 ` Avi Kivity
2012-02-01 13:56 ` Alex Williamson
2012-01-28 14:21 ` [PATCH 4/9] pci-assign: Use struct for MSI-X table Alex Williamson
2012-01-31 17:40 ` Michael S. Tsirkin
2012-01-31 19:05 ` Alex Williamson
2012-01-31 20:00 ` Michael S. Tsirkin
2012-01-31 21:17 ` Alex Williamson
2012-01-31 21:24 ` Michael S. Tsirkin
2012-01-31 21:30 ` Alex Williamson
2012-01-28 14:22 ` [PATCH 5/9] pci-assign: Only calculate maximum MSI-X vector entries once Alex Williamson
2012-01-31 20:18 ` Michael S. Tsirkin
2012-01-31 20:31 ` Alex Williamson
2012-01-31 20:56 ` Michael S. Tsirkin
2012-01-28 14:22 ` [PATCH 6/9] pci-assign: Proper initialization for MSI-X table Alex Williamson
2012-01-31 17:40 ` Michael S. Tsirkin
2012-01-31 19:07 ` Alex Williamson
2012-01-31 19:12 ` Michael S. Tsirkin
2012-01-31 19:16 ` Jan Kiszka
2012-01-31 20:19 ` Michael S. Tsirkin
2012-01-31 21:06 ` Alex Williamson
2012-01-28 14:22 ` [PATCH 7/9] pci-assign: Allocate entries for all MSI-X vectors Alex Williamson
2012-01-28 14:22 ` [PATCH 8/9] pci-assign: Use MSIX_PAGE_SIZE Alex Williamson
2012-01-28 14:22 ` [PATCH 9/9] pci-assign: Update MSI-X config based on table writes Alex Williamson
2012-01-31 12:50 ` Avi Kivity
2012-01-30 10:11 ` [PATCH 0/9] pci-assign: 64bit MMIO + better MSI-X table support Jan Kiszka
2012-01-30 13:44 ` Alex Williamson
2012-01-31 12:52 ` Avi Kivity
2012-01-31 12:56 ` Jan Kiszka [this message]
2012-02-06 15:55 ` Shashidhar Patil
2012-02-06 17:29 ` Alex Williamson
2012-02-09 16:23 ` Shashidhar Patil
2012-02-09 17:23 ` Alex Williamson
2012-02-12 16:30 ` Shashidhar Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F27E4EF.5000204@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=alex.williamson@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=shashidhar.patil@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).