From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] KVM call agenda for tuesday 31
Date: Tue, 31 Jan 2012 08:12:29 -0600
Message-ID: <4F27F6CD.1000807@codemonkey.ws>
References: <87ehuhrpel.fsf@elfo.elfo> <4F272A92.2010609@suse.de>	<4F272D8C.8020608@codemonkey.ws> <4F27E98E.2080501@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
	format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: quintela@redhat.com, Mitsyanko Igor <i.mitsyanko@samsung.com>,
	Developers qemu-devel <qemu-devel@nongnu.org>,
	KVM devel mailing list <kvm@vger.kernel.org>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-pw0-f46.google.com ([209.85.160.46]:38958 "EHLO
	mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752904Ab2AaOMd (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 31 Jan 2012 09:12:33 -0500
Received: by pbdu11 with SMTP id u11so195679pbd.19
        for <kvm@vger.kernel.org>; Tue, 31 Jan 2012 06:12:33 -0800 (PST)
In-Reply-To: <4F27E98E.2080501@suse.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 01/31/2012 07:15 AM, Andreas F=C3=A4rber wrote:
> Am 31.01.2012 00:53, schrieb Anthony Liguori:
>> On 01/30/2012 05:41 PM, Andreas F=C3=A4rber wrote:
>>> Am 30.01.2012 19:55, schrieb Juan Quintela:
>>>> Please send in any agenda items you are interested in covering.
>
>>> VMState:
>>> Anthony specifically said that VMState were not affected by QOM and=
 that
>>> patches should not be deferred until the merge. Yet there's no revi=
ew
>>> and/or decision-making for a month now. Ping^2 for AHCI+SDHC.
>>
>> Do you have pointers (to pending VMState patches)?
>
> http://patchwork.ozlabs.org/patch/137732/ (PATCH v4)
>
> It's basically about how to deal with variable-sized arrays. (Alex
> mentioned it on one call around November.) I found ways to deal with
> subsets of arrays embedded within the struct and variable-sized list =
of
> pointers to structs but no solution for a malloc()'ed array of struct=
s.
> Maybe I'm just too stupid to see. Anyway, no one commented since Xmas=
=2E

/me puts on his flame proof suit

Don't use VMState.  Just open code a save/restore function.  VMState is=
 too=20
limited in how it handles complex data structures.

I really believe the only long term solution we're going to get to here=
 is=20
something that uses a builder interface (like Visitors).

Regards,

Anthony Liguori

>
> Igor posted (and refined for v2) a patch with a callback-based approa=
ch
> that I find promising. From my view, unofficially Juan is the VMState
> guy, he's been cc'ed. Are we lacking an official maintainer that care=
s?
> Or is Juan the official, undocumented maintainer but simply busy?
>
> SUSE's interest is making AHCI migratable, and my VMState workaround =
for
> that is simply ugly:
>
> http://patchwork.ozlabs.org/patch/133066/ (RFC)
>
> Therefore I'm waiting for some resolution.
>
> Regards,
> Andreas
>