From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] KVM call agenda for tuesday 31
Date: Tue, 31 Jan 2012 16:12:14 +0100
Message-ID: <4F2804CE.40407@redhat.com>
References: <87ehuhrpel.fsf@elfo.elfo> <4F272A92.2010609@suse.de>	<4F272D8C.8020608@codemonkey.ws> <4F27E98E.2080501@suse.de> <4F27F6CD.1000807@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>,
	quintela@redhat.com, Mitsyanko Igor <i.mitsyanko@samsung.com>,
	Developers qemu-devel <qemu-devel@nongnu.org>,
	KVM devel mailing list <kvm@vger.kernel.org>
To: Anthony Liguori <anthony@codemonkey.ws>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-yx0-f174.google.com ([209.85.213.174]:41002 "EHLO
	mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752193Ab2AaPMW (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 31 Jan 2012 10:12:22 -0500
Received: by yenm8 with SMTP id m8so59409yen.19
        for <kvm@vger.kernel.org>; Tue, 31 Jan 2012 07:12:22 -0800 (PST)
In-Reply-To: <4F27F6CD.1000807@codemonkey.ws>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 01/31/2012 03:12 PM, Anthony Liguori wrote:
>
> Don't use VMState.  Just open code a save/restore function.  VMState is
> too limited in how it handles complex data structures.
>
> I really believe the only long term solution we're going to get to here
> is something that uses a builder interface (like Visitors).

Visitors for complex data structures still require you separate get/set 
functions.  VMState was created to avoid having to write things twice 
and avoid getting the two out of sync.

Paolo