From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 6/9] pci-assign: Proper initialization for MSI-X table Date: Tue, 31 Jan 2012 20:16:31 +0100 Message-ID: <4F283E0F.6000302@siemens.com> References: <20120128142104.25681.93072.stgit@bling.home> <20120128142209.25681.10074.stgit@bling.home> <20120131174042.GB3601@redhat.com> <1328036859.6937.101.camel@bling.home> <20120131191233.GD3601@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Alex Williamson , "kvm@vger.kernel.org" , "shashidhar.patil@gmail.com" To: "Michael S. Tsirkin" Return-path: Received: from david.siemens.de ([192.35.17.14]:25962 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752898Ab2AaTQf (ORCPT ); Tue, 31 Jan 2012 14:16:35 -0500 In-Reply-To: <20120131191233.GD3601@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2012-01-31 20:12, Michael S. Tsirkin wrote: > On Tue, Jan 31, 2012 at 12:07:39PM -0700, Alex Williamson wrote: >> On Tue, 2012-01-31 at 19:40 +0200, Michael S. Tsirkin wrote: >>> On Sat, Jan 28, 2012 at 07:22:09AM -0700, Alex Williamson wrote: >>>> Per the PCI spec, all vectors should be masked at handoff. >>>> >>>> Signed-off-by: Alex Williamson >>>> --- >>>> >>>> hw/device-assignment.c | 20 +++++++++++++++++++- >>>> 1 files changed, 19 insertions(+), 1 deletions(-) >>>> >>>> diff --git a/hw/device-assignment.c b/hw/device-assignment.c >>>> index af614d3..6efa219 100644 >>>> --- a/hw/device-assignment.c >>>> +++ b/hw/device-assignment.c >>>> @@ -1462,6 +1462,22 @@ static const MemoryRegionOps msix_mmio_ops = { >>>> }, >>>> }; >>>> >>>> +static void msix_reset(AssignedDevice *dev) >>>> +{ >>>> + MSIXTableEntry *entry; >>>> + int i; >>>> + >>>> + if (!dev->msix_table) { >>>> + return; >>>> + } >>>> + >>>> + memset(dev->msix_table, 0, 0x1000); >>>> + >>>> + for (i = 0, entry = dev->msix_table; i < dev->msix_max; i++, entry++) { >>>> + entry->ctrl = 0x1; /* Masked */ >>> >>> This is broken for BE hosts. >> >> Show me a BE host that even remotely works with this device assignment >> implementation. Thanks, >> >> Alex > > I don't get it. Yes lots of cleanup is needed but why add more broken > code? At some point, we will just do this via the PCI core, and that will have to do it correctly anyway. This code here is supposed to be removed again. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux