From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 6/7] pcspk: Convert to qdev
Date: Wed, 01 Feb 2012 08:29:51 +0100
Message-ID: <4F28E9EF.9000706@redhat.com>
References: <cover.1328031687.git.jan.kiszka@siemens.com> <c101f29d71634c6c8d70a14d59664e75f11b7d3f.1328031687.git.jan.kiszka@siemens.com> <4F2853EA.3030808@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Blue Swirl <blauwirbel@gmail.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Avi Kivity <avi@redhat.com>, kvm <kvm@vger.kernel.org>
To: Anthony Liguori <anthony@codemonkey.ws>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-pw0-f46.google.com ([209.85.160.46]:44897 "EHLO
	mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752216Ab2BAH36 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 1 Feb 2012 02:29:58 -0500
Received: by pbdu11 with SMTP id u11so851840pbd.19
        for <kvm@vger.kernel.org>; Tue, 31 Jan 2012 23:29:58 -0800 (PST)
In-Reply-To: <4F2853EA.3030808@codemonkey.ws>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 01/31/2012 09:49 PM, Anthony Liguori wrote:
>>
>> +        DEFINE_PROP_HEX32("iobase", PCSpkState, iobase,  -1),
>> +        DEFINE_PROP_PTR("pit", PCSpkState, pit),
>
> Please don't introduce a pointer property here.  They cannot be used in
> a meaningful way in qdev.  Why not register a link<TYPE_PIT> in
> instance_init?

I'm going to clean this up, you can leave the PTR for now.

Paolo