From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [Qemu-devel] [PATCH v3 6/7] pcspk: Convert to qdev
Date: Wed, 01 Feb 2012 10:18:41 +0100
Message-ID: <4F290371.1040601@siemens.com>
References: <cover.1328031687.git.jan.kiszka@siemens.com> <c101f29d71634c6c8d70a14d59664e75f11b7d3f.1328031687.git.jan.kiszka@siemens.com> <4F2853EA.3030808@codemonkey.ws> <4F28E9EF.9000706@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Anthony Liguori <anthony@codemonkey.ws>,
	Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	Blue Swirl <blauwirbel@gmail.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Avi Kivity <avi@redhat.com>, kvm <kvm@vger.kernel.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from goliath.siemens.de ([192.35.17.28]:15600 "EHLO
	goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753807Ab2BAJSz (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 1 Feb 2012 04:18:55 -0500
In-Reply-To: <4F28E9EF.9000706@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 2012-02-01 08:29, Paolo Bonzini wrote:
> On 01/31/2012 09:49 PM, Anthony Liguori wrote:
>>>
>>> +        DEFINE_PROP_HEX32("iobase", PCSpkState, iobase,  -1),
>>> +        DEFINE_PROP_PTR("pit", PCSpkState, pit),
>>
>> Please don't introduce a pointer property here.  They cannot be used in
>> a meaningful way in qdev.  Why not register a link<TYPE_PIT> in
>> instance_init?
> 
> I'm going to clean this up, you can leave the PTR for now.

OK, will then ship v4 with this property still in place and count on you.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux