public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Christoffer Dall <cdall@cs.columbia.edu>, kvm <kvm@vger.kernel.org>
Subject: Re: Partial review of kvm arm git patches.
Date: Wed, 01 Feb 2012 11:38:21 +0200	[thread overview]
Message-ID: <4F29080D.8020100@redhat.com> (raw)
In-Reply-To: <871uqfjcf9.fsf@rustcorp.com.au>

On 02/01/2012 08:27 AM, Rusty Russell wrote:
> > +#define VM_STAT(x) (offsetof(struct kvm, stat.x), KVM_STAT_VM)
> > +#define VCPU_STAT(x) (offsetof(struct kvm_vcpu, stat.x), KVM_STAT_VCPU)
> > +
> > +struct kvm_stats_debugfs_item debugfs_entries[] = {
> > +       { NULL }
> > +};
>
> That's weird.  I see it's used in x86, not here though.

Should just be removed.  We're deprecating the debugfs stats in favour
of tracepoints.

Welcome back to virt-land!

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2012-02-01  9:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-01  6:27 Partial review of kvm arm git patches Rusty Russell
2012-02-01  9:38 ` Avi Kivity [this message]
2012-02-01 14:23 ` Christoffer Dall
  -- strict thread matches above, loose matches on Subject: below --
2012-02-02  5:04 Rusty Russell
2012-02-02 14:48 ` Christoffer Dall
2012-02-06 23:13   ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F29080D.8020100@redhat.com \
    --to=avi@redhat.com \
    --cc=cdall@cs.columbia.edu \
    --cc=kvm@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox