From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Partial review of kvm arm git patches. Date: Wed, 01 Feb 2012 11:38:21 +0200 Message-ID: <4F29080D.8020100@redhat.com> References: <871uqfjcf9.fsf@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Christoffer Dall , kvm To: Rusty Russell Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36090 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753917Ab2BAJib (ORCPT ); Wed, 1 Feb 2012 04:38:31 -0500 In-Reply-To: <871uqfjcf9.fsf@rustcorp.com.au> Sender: kvm-owner@vger.kernel.org List-ID: On 02/01/2012 08:27 AM, Rusty Russell wrote: > > +#define VM_STAT(x) (offsetof(struct kvm, stat.x), KVM_STAT_VM) > > +#define VCPU_STAT(x) (offsetof(struct kvm_vcpu, stat.x), KVM_STAT_VCPU) > > + > > +struct kvm_stats_debugfs_item debugfs_entries[] = { > > + { NULL } > > +}; > > That's weird. I see it's used in x86, not here though. Should just be removed. We're deprecating the debugfs stats in favour of tracepoints. Welcome back to virt-land! -- error compiling committee.c: too many arguments to function