From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [Qemu-devel] [PATCH 1/4] i8254: Factor out base class for KVM reuse Date: Wed, 01 Feb 2012 13:23:45 +0100 Message-ID: <4F292ED1.3060901@redhat.com> References: <1e206a3b5dbd396606099fdbd9abd8c00bbdda31.1328035554.git.jan.kiszka@siemens.com> <4F285FBA.5050607@codemonkey.ws> <4F2861F4.1000604@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit To: "kvm@vger.kernel.org" , qemu-devel , Anthony Liguori , Marcelo Tosatti , Jan Kiszka Return-path: Received: from mail-pz0-f46.google.com ([209.85.210.46]:39485 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753370Ab2BAMXx (ORCPT ); Wed, 1 Feb 2012 07:23:53 -0500 Received: by dadp15 with SMTP id p15so827954dad.19 for ; Wed, 01 Feb 2012 04:23:52 -0800 (PST) In-Reply-To: <4F2861F4.1000604@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 01/31/2012 10:49 PM, Jan Kiszka wrote: > > Just make the methods that you want to override virtual with the default > > implementation and then make a KVMPIT that inherits from the PIT and > > then overrides whatever virtual functions it needs to. > > That doesn't sound like the proper design for this purpose. Rather, we > have an abstract base class that both implementations are derived from. Absolutely! > If I'm not using QOM properly to achieve this, please tell me. It looks good, besides the need to rebase to Anthony's "part 3" changes. Paolo