From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 1/4] i8254: Factor out base class for KVM reuse Date: Wed, 01 Feb 2012 07:19:19 -0600 Message-ID: <4F293BD7.4080503@codemonkey.ws> References: <1e206a3b5dbd396606099fdbd9abd8c00bbdda31.1328035554.git.jan.kiszka@siemens.com> <4F285FBA.5050607@codemonkey.ws> <4F2861F4.1000604@web.de> <4F292ED1.3060901@redhat.com> <4F293361.2000300@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Paolo Bonzini , Marcelo Tosatti , qemu-devel , "kvm@vger.kernel.org" To: Jan Kiszka Return-path: In-Reply-To: <4F293361.2000300@siemens.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 02/01/2012 06:43 AM, Jan Kiszka wrote: > On 2012-02-01 13:23, Paolo Bonzini wrote: >> On 01/31/2012 10:49 PM, Jan Kiszka wrote: >>>> Just make the methods that you want to override virtual with the default >>>> implementation and then make a KVMPIT that inherits from the PIT and >>>> then overrides whatever virtual functions it needs to. >>> >>> That doesn't sound like the proper design for this purpose. Rather, we >>> have an abstract base class that both implementations are derived from. >> >> Absolutely! >> >>> If I'm not using QOM properly to achieve this, please tell me. >> >> It looks good, besides the need to rebase to Anthony's "part 3" changes. > > Given that this part is not upstream and that the relevant conversion is > scripted, I would leave this to Anthony so far. Or what is the schedule? I haven't run through regression testing yet so YMMV but the latest series is at: https://github.com/aliguori/qemu/tree/qom-upstream.13 Regards, Anthony Liguori > > Jan >