From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2 1/3] KVM: x86: move kvm_exit related definitions into kvm_exit.h Date: Thu, 02 Feb 2012 19:30:00 +0200 Message-ID: <4F2AC818.1000905@redhat.com> References: <4F2AC707.7020801@gmail.com> <4F2AC753.4020905@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Ingo Molnar , Arnaldo Carvalho de Melo , Stefan Hajnoczi , LKML , KVM To: Xiao Guangrong Return-path: In-Reply-To: <4F2AC753.4020905@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 02/02/2012 07:26 PM, Xiao Guangrong wrote: > From: Xiao Guangrong > > Move the definitions into a separate .h file so that 'perf kvm-events' can > easily use these Why not just include vmx.h and svm.h? I don't like scattering those definitions around. > Signed-off-by: Xiao Guangrong > --- > arch/x86/include/asm/kvm_exit.h | 229 +++++++++++++++++++++++++++++++++++++++ Especially as this file doesn't make a distinction between vmx and svm. -- error compiling committee.c: too many arguments to function