kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
	Takuya Yoshikawa <takuya.yoshikawa@gmail.com>,
	mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH for 3.3] KVM: Fix write protection race during dirty logging
Date: Mon, 06 Feb 2012 11:48:12 +0200	[thread overview]
Message-ID: <4F2FA1DC.8050208@redhat.com> (raw)
In-Reply-To: <4F2F6146.8070804@oss.ntt.co.jp>

On 02/06/2012 07:12 AM, Takuya Yoshikawa wrote:
> (2012/02/06 14:02), Xiao Guangrong wrote:
>
>> I am worrying if other paths(such as like
>> kvm_mmu_notifier_invalidate_page)
>> which unmap/modify writeable ptes and flush TLBs out of mmu lock have
>> the
>> same problem?
>>
>
> Yes, I think so ... (long standing bug?)

Ugh, I looked at arch/x86/kvm for this problem but not at virt/kvm.

>
> Let's ask Avi if he prefers to fix it separately then!

Separate fixes please.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2012-02-06  9:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-05 11:42 [PATCH for 3.3] KVM: Fix write protection race during dirty logging Takuya Yoshikawa
2012-02-06  3:40 ` Xiao Guangrong
2012-02-06  3:46   ` Takuya Yoshikawa
2012-02-06  3:53     ` Xiao Guangrong
2012-02-06  5:02       ` Xiao Guangrong
2012-02-06  5:12         ` Takuya Yoshikawa
2012-02-06  9:48           ` Avi Kivity [this message]
2012-02-08 16:38 ` Marcelo Tosatti
2012-02-09 13:54   ` Takuya Yoshikawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F2FA1DC.8050208@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=takuya.yoshikawa@gmail.com \
    --cc=xiaoguangrong@linux.vnet.ibm.com \
    --cc=yoshikawa.takuya@oss.ntt.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).