From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH for 3.3] KVM: Fix write protection race during dirty logging Date: Mon, 06 Feb 2012 11:48:12 +0200 Message-ID: <4F2FA1DC.8050208@redhat.com> References: <20120205204241.54f16069c7f10ac7524c55ec@gmail.com> <4F2F4B99.6050902@linux.vnet.ibm.com> <4F2F4D06.8020303@oss.ntt.co.jp> <4F2F4EB6.4040105@linux.vnet.ibm.com> <4F2F5EE2.5080703@linux.vnet.ibm.com> <4F2F6146.8070804@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Xiao Guangrong , Takuya Yoshikawa , mtosatti@redhat.com, kvm@vger.kernel.org To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:61543 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754075Ab2BFJsX (ORCPT ); Mon, 6 Feb 2012 04:48:23 -0500 In-Reply-To: <4F2F6146.8070804@oss.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 02/06/2012 07:12 AM, Takuya Yoshikawa wrote: > (2012/02/06 14:02), Xiao Guangrong wrote: > >> I am worrying if other paths(such as like >> kvm_mmu_notifier_invalidate_page) >> which unmap/modify writeable ptes and flush TLBs out of mmu lock have >> the >> same problem? >> > > Yes, I think so ... (long standing bug?) Ugh, I looked at arch/x86/kvm for this problem but not at virt/kvm. > > Let's ask Avi if he prefers to fix it separately then! Separate fixes please. -- error compiling committee.c: too many arguments to function