From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v2] KVM: Factor out kvm_vcpu_kick to arch-generic code Date: Mon, 06 Feb 2012 21:06:04 +0100 Message-ID: <4F3032AC.10809@web.de> References: <20120125042739.16236.95639.stgit@localhost> <20120206182504.GC19821@amt.cnet> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigBD92A7818E522991C82B9BFB" Cc: Christoffer Dall , kvm@vger.kernel.org, Marc.Zyngier@arm.com, agraf@suse.de, kvm-ppc@vger.kernel.org, avi@redhat.com, tech@virtualopensystems.com To: Marcelo Tosatti Return-path: In-Reply-To: <20120206182504.GC19821@amt.cnet> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigBD92A7818E522991C82B9BFB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2012-02-06 19:25, Marcelo Tosatti wrote: >> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c >> index c38efd7..a1761ff 100644 >> --- a/arch/x86/kvm/x86.c >> +++ b/arch/x86/kvm/x86.c >> @@ -2252,7 +2252,6 @@ void kvm_arch_vcpu_load(struct kvm_vcpu *vcpu, i= nt cpu) >> kvm_make_request(KVM_REQ_CLOCK_UPDATE, vcpu); >> if (vcpu->cpu !=3D cpu) >> kvm_migrate_timers(vcpu); >> - vcpu->cpu =3D cpu; >> } >=20 > This is wrong, kvm_sched_in fails to see vcpu->cpu properly. Please > keep vcpu->cpu assignment in arch code. True, but then kvm_sched_in is a better place for this assignment (as it's central), no? Jan --------------enigBD92A7818E522991C82B9BFB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8wMrIACgkQitSsb3rl5xQeUwCcCNEmg2f7yufEFzDAvoGAH92o rB8AniRO6MliGHbpWl9zzbMJxFSRV+mk =fW++ -----END PGP SIGNATURE----- --------------enigBD92A7818E522991C82B9BFB--