From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [Qemu-devel] [PATCH v2 1/8] kvm: Set cpu_single_env only once Date: Sat, 11 Feb 2012 13:43:25 +0100 Message-ID: <4F36626D.7020109@web.de> References: <4F363DB2.3080908@web.de> <4F3655E7.3090905@suse.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig619DFD3466A330D1030E2C39" Cc: Blue Swirl , Anthony Liguori , kvm@vger.kernel.org, Gleb Natapov , Marcelo Tosatti , qemu-devel , Avi Kivity To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:45091 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755040Ab2BKMna (ORCPT ); Sat, 11 Feb 2012 07:43:30 -0500 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate02.web.de (Postfix) with ESMTP id 4E60A1C0FC7E6 for ; Sat, 11 Feb 2012 13:43:26 +0100 (CET) In-Reply-To: <4F3655E7.3090905@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig619DFD3466A330D1030E2C39 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2012-02-11 12:49, Andreas F=C3=A4rber wrote: > Am 11.02.2012 12:25, schrieb Blue Swirl: >> I think using cpu_single_env is an indication of a problem, like poor >> code, layering violation or poor API (vmport). What is your use case? >=20 > I couldn't spot any in this series. Jan, note that any new use of env o= r > cpu_single_env will need to be redone when we convert to QOM CPU. cpu_single_env should have nothing to do with QOM. The ABIs of vmport and the KVM VAPI require a reference to the calling VCPU, and that's why you find tons of them in patch 5. Jan --------------enig619DFD3466A330D1030E2C39 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEUEARECAAYFAk82Ym0ACgkQitSsb3rl5xQYmQCYnxEWdyLtUofd1BzfNxVxPx9n UQCfXSzYYlcfR95Mhmp08D3RFqW51A4= =Jd8c -----END PGP SIGNATURE----- --------------enig619DFD3466A330D1030E2C39--