From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v2 7/8] optionsrom: Reserve space for checksum Date: Sat, 11 Feb 2012 13:45:29 +0100 Message-ID: <4F3662E9.9040803@web.de> References: <104a9888a110afd0df281925dca2f05a64fa0ac6.1328898681.git.jan.kiszka@siemens.com> <4F36552A.3060604@suse.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig299DD3837A64D7DC15AA2CE0" Cc: Anthony Liguori , kvm@vger.kernel.org, Gleb Natapov , Marcelo Tosatti , qemu-devel , Avi Kivity To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Return-path: Received: from fmmailgate04.web.de ([217.72.192.242]:33144 "EHLO fmmailgate04.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754945Ab2BKMpb (ORCPT ); Sat, 11 Feb 2012 07:45:31 -0500 Received: from moweb002.kundenserver.de (moweb002.kundenserver.de [172.19.20.108]) by fmmailgate04.web.de (Postfix) with ESMTP id 1A25E715032D for ; Sat, 11 Feb 2012 13:45:30 +0100 (CET) In-Reply-To: <4F36552A.3060604@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig299DD3837A64D7DC15AA2CE0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2012-02-11 12:46, Andreas F=E4rber wrote: > Am 10.02.2012 19:31, schrieb Jan Kiszka: >> Always add a byte before the final 512-bytes alignment to reserve the >> space for the ROM checksum. >> >> Signed-off-by: Jan Kiszka >> --- >> pc-bios/optionrom/optionrom.h | 3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/pc-bios/optionrom/optionrom.h b/pc-bios/optionrom/optionr= om.h >> index aa783de..3daf7da 100644 >> --- a/pc-bios/optionrom/optionrom.h >> +++ b/pc-bios/optionrom/optionrom.h >> @@ -124,7 +124,8 @@ >> movw %ax, %ds; >> =20 >> #define OPTION_ROM_END \ >> - .align 512, 0; \ >> + .byte 0; \ >> + .align 512, 0; \ >=20 > Tabs. For sure, like in the whole file. If a codestyle fix is desired, I'll post one for all assembly files. But I guess there are different views on such changes. Jan --------------enig299DD3837A64D7DC15AA2CE0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk82YukACgkQitSsb3rl5xSAvACfX/9Cw7Tdrjcb5WnSIOyF5ObC MHYAoIRh33Py3cFnPfjkMwBmCvYhNfJ+ =y6/j -----END PGP SIGNATURE----- --------------enig299DD3837A64D7DC15AA2CE0--