From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH 3/3] KVM: perf: kvm events analysis tool Date: Mon, 13 Feb 2012 08:52:54 -0700 Message-ID: <4F3931D6.2090305@gmail.com> References: <4F38E091.5070504@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti , Ingo Molnar , Arnaldo Carvalho de Melo , LKML , KVM To: Xiao Guangrong Return-path: Received: from mail-pw0-f46.google.com ([209.85.160.46]:54657 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757012Ab2BMPw7 (ORCPT ); Mon, 13 Feb 2012 10:52:59 -0500 In-Reply-To: <4F38E091.5070504@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/13/2012 03:06 AM, Xiao Guangrong wrote: > On 02/13/2012 01:32 PM, David Ahern wrote: > >> [sorry for the top post - you would think Android would have a better mail client] >> >> If the first patch is needed then kvm-events will not work with older, unpatched kernels. That's a big limitation from a perf perpective. >> > > > The first patch is only needed for code compilation, after kvm-events is > compiled, you can analyse any kernels. :) understood. Now that I recall perf's way of handling out of tree builds, a couple of comments: 1. you need to add the following to tools/perf/MANIFEST arch/x86/include/asm/svm.h arch/x86/include/asm/vmx.h arch/x86/include/asm/kvm_host.h 2.scripts/checkpatch.pl is an unhappy camper. I'll take a look at the code and try out the command when I get some time. David