From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH uq/master] Synchronize cpu state with kernel before poking
 into registers.
Date: Thu, 16 Feb 2012 13:55:33 +0100
Message-ID: <4F3CFCC5.5010308@siemens.com>
References: <20120216091251.GD19771@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, avi@redhat.com, mtosatti@redhat.com,
	qemu-devel <qemu-devel@nongnu.org>
To: Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from david.siemens.de ([192.35.17.14]:16231 "EHLO david.siemens.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751323Ab2BPMzr (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 16 Feb 2012 07:55:47 -0500
In-Reply-To: <20120216091251.GD19771@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 2012-02-16 10:12, Gleb Natapov wrote:
> Call to kvm_cpu_synchronize_state() is missing. kvm_arch_stop_on_emulation_error may
> look at outdated registers here.
> 
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 7079e87..51d0ae7 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -2020,6 +2020,7 @@ int kvm_arch_handle_exit(CPUState *env, struct kvm_run *run)
>  
>  bool kvm_arch_stop_on_emulation_error(CPUState *env)
>  {
> +    kvm_cpu_synchronize_state(env);
>      return !(env->cr[0] & CR0_PE_MASK) ||
>             ((env->segs[R_CS].selector  & 3) != 3);
>  }

Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux