From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mitsyanko Igor Subject: Re: [Qemu-devel] KVM call agenda for tuesday 31 Date: Wed, 22 Feb 2012 12:06:35 +0400 Message-ID: <4F44A20B.2010506@samsung.com> References: <87ehuhrpel.fsf@elfo.elfo> <4F272A92.2010609@suse.de> <4F272D8C.8020608@codemonkey.ws> <4F27E98E.2080501@suse.de> Reply-To: i.mitsyanko@samsung.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7BIT Cc: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Anthony Liguori , quintela@redhat.com, Developers qemu-devel , KVM devel mailing list To: Peter Maydell Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:61775 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753440Ab2BVIGn (ORCPT ); Wed, 22 Feb 2012 03:06:43 -0500 Received: from euspt2 (mailout1.w1.samsung.com [210.118.77.11]) by mailout1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0LZS0061TBV5HU@mailout1.w1.samsung.com> for kvm@vger.kernel.org; Wed, 22 Feb 2012 08:06:41 +0000 (GMT) Received: from [106.109.8.162] by spt2.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LZS00LJRBV4C5@spt2.w1.samsung.com> for kvm@vger.kernel.org; Wed, 22 Feb 2012 08:06:41 +0000 (GMT) In-reply-to: Sender: kvm-owner@vger.kernel.org List-ID: On 02/21/2012 07:33 PM, Peter Maydell wrote: > Short summary: > * switch wp groups to bitfield rather than int array > * convert sd.c to use memory_region_init_ram() to allocate the wp groups > (being careful to use memory_region_set_dirty() when we touch them) > * we don't need variable-length fields for sd.c any more > * rest of the vmstate conversion is straightforward OK, got it. But it's not clear to me, have you decided against introducing .get_bufsize completely or just for sd.c? I still think it's a good idea and I wouldn't mind to use it in SD host controller implementation to retrieve buffer size directly from capabilities register, but I can take another approach for this of course. -- Mitsyanko Igor ASWG, Moscow R&D center, Samsung Electronics email: i.mitsyanko@samsung.com