From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Reconciling qemu-kvm and qemu's PIT Date: Wed, 29 Feb 2012 15:45:18 +0200 Message-ID: <4F4E2BEE.3010801@redhat.com> References: <4F4CE596.9070302@redhat.com> <4F4CE743.7050107@siemens.com> <4F4CE7CB.8090409@redhat.com> <4F4D2FED.1030207@redhat.com> <4F4D4B8B.3080201@web.de> <4F4DF003.3000001@redhat.com> <4F4DFA6E.4030101@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: KVM list To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:19835 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030223Ab2B2NpX (ORCPT ); Wed, 29 Feb 2012 08:45:23 -0500 In-Reply-To: <4F4DFA6E.4030101@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/29/2012 12:14 PM, Jan Kiszka wrote: > On 2012-02-29 10:29, Avi Kivity wrote: > > On 02/28/2012 11:47 PM, Jan Kiszka wrote: > >>> > >>> Looks like isa-pit has zero gpio pins, so it fails when crashing. I > >>> must have mismerged it, but where is the gpio pin count set? > >> > >> In pit_initfn. Does -no-kvm-irqchip work fine? It's a bit tricky to > >> discuss this without seeing your code. > >> > > > > pushed it into qemu-kvm.git usptream-merge > > > > As I assumed: You try to initialize the kvm-pit like the userspace pit, > that cannot work. Don't run the qdev_connect_gpio_out in pit_init, just > like my kvm-pit patches does in their kvm_pit_init. > The merge is now in 'next', hopefully not too many regressions. -- error compiling committee.c: too many arguments to function