From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Blake Subject: Re: [Qemu-devel] [PULL] Urgent memory fix for kvm with unaligned memory slots Date: Thu, 01 Mar 2012 10:08:47 -0700 Message-ID: <4F4FAD1F.7080603@redhat.com> References: <4F4F7C47.6090005@redhat.com> <4F4FABD7.1030709@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig94B50F003394F3D165BAFF1E" Cc: Bobby Powers , qemu-devel , Anthony Liguori , KVM list To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:33722 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758760Ab2CARIy (ORCPT ); Thu, 1 Mar 2012 12:08:54 -0500 In-Reply-To: <4F4FABD7.1030709@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig94B50F003394F3D165BAFF1E Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 03/01/2012 10:03 AM, Avi Kivity wrote: >>> >>> - ram =3D memory_region_get_ram_ptr(mr) + section->offset_within_r= egion; >>> + ram =3D memory_region_get_ram_ptr(mr) + section->offset_within_r= egion >>> + delta; >> >> Am I crazy, or does this look wrong? >=20 > Could be both. Why do you thing it is wrong? Line wrapping makes it look like we are adding two lines, one line ending in 'section->offset_within_region', and the next line starting with 'delta;', which is a syntax error. But without line wrapping, we are adding just one line with 'offset_within_region + delta;' at the end of that line. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig94B50F003394F3D165BAFF1E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPT60fAAoJEKeha0olJ0Nq4tcH/jr4JcJjweB3pRidpgo5ajtP mkh+QM2ZJpegLbnn3QkKhu63EDJ1/c+YBh0o4xDqKy9kf7KZ+Em1FiR2Kxt3iNG9 XR3+1Vs5U+kHee4C8PlHpOHHGnKAyw5teOpT7z0PWccB0dqjVirn7V3IPAsvyyJ9 CKa1FpO3hkRJnR7kBnhFSar0EkUj1LIhh7NsFpy9oBY72tKgIZEPM6K5vF6uhLlv 4sk5s0FQt1ejg3zdZEar2w6h/K20UizoVqHcWqaAFGSeClgGNtDZd3MMmXwcegth JD9yvxCfpJqF4wT5HXE34nHd2FcuCMxr1SN7WQevM2eKJWKl0blQ11+qntR4vKA= =XblY -----END PGP SIGNATURE----- --------------enig94B50F003394F3D165BAFF1E--