From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PULL] Urgent memory fix for kvm with unaligned memory slots Date: Thu, 01 Mar 2012 19:13:38 +0200 Message-ID: <4F4FAE42.7010103@redhat.com> References: <4F4F7C47.6090005@redhat.com> <4F4FABD7.1030709@redhat.com> <4F4FAD1F.7080603@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Bobby Powers , qemu-devel , Anthony Liguori , KVM list To: Eric Blake Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39906 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758799Ab2CARNr (ORCPT ); Thu, 1 Mar 2012 12:13:47 -0500 In-Reply-To: <4F4FAD1F.7080603@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/01/2012 07:08 PM, Eric Blake wrote: > On 03/01/2012 10:03 AM, Avi Kivity wrote: > >>> > >>> - ram = memory_region_get_ram_ptr(mr) + section->offset_within_region; > >>> + ram = memory_region_get_ram_ptr(mr) + section->offset_within_region > >>> + delta; > >> > >> Am I crazy, or does this look wrong? > > > > Could be both. Why do you thing it is wrong? > > Line wrapping makes it look like we are adding two lines, one line > ending in 'section->offset_within_region', and the next line starting > with 'delta;', which is a syntax error. > > But without line wrapping, we are adding just one line with > 'offset_within_region + delta;' at the end of that line. > Ah, of course. I just copy/pasted this into thunderbird, this is not a proper patch but a pull request. Sorry about the confusion. Bobby: so it does indeed look wrong. This says nothing about your sanity though, for that consult a qualified professional instead of asking on the mailing list. -- error compiling committee.c: too many arguments to function