From mboxrd@z Thu Jan  1 00:00:00 1970
From: Amos Kong <akong@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] net: split hostname and service by last
 colon
Date: Fri, 02 Mar 2012 11:38:38 +0800
Message-ID: <4F5040BE.2000807@redhat.com>
References: <20120210062608.13397.43361.stgit@dhcp-8-167.nay.redhat.com> <20120210062719.13397.9953.stgit@dhcp-8-167.nay.redhat.com> <4F475874.8050803@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: aliguori@us.ibm.com, kvm@vger.kernel.org, quintela@redhat.com,
	jasowang@redhat.com, qemu-devel@nongnu.org, laine@redhat.com
To: Kevin Wolf <kwolf@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:17915 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757814Ab2CBDip (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 1 Mar 2012 22:38:45 -0500
In-Reply-To: <4F475874.8050803@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 24/02/12 17:29, Kevin Wolf wrote:
> Am 10.02.2012 07:27, schrieb Amos Kong:
>> IPv6 address contains colons, parse will be wrong.
>>
>>      [2312::8274]:5200
>>
>> Signed-off-by: Amos Kong<akong@redhat.com>
>> ---
>>   net.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/net.c b/net.c
>> index f63014c..9e1ef9e 100644
>> --- a/net.c
>> +++ b/net.c
>> @@ -84,7 +84,7 @@ static int get_str_sep(char *buf, int buf_size, const char **pp, int sep)
>>       const char *p, *p1;
>>       int len;
>>       p = *pp;
>> -    p1 = strchr(p, sep);
>> +    p1 = strrchr(p, sep);
>>       if (!p1)
>>           return -1;
>>       len = p1 - p;
>
> And what if the port isn't specified? I think you would erroneously
> interpret the last part of the IP address as port.

IPv6 address have paired colons, need more precision check.

-- 
			Amos.