From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: x86: Avoid NULL dereference in kvm_apic_accept_pic_intr() Date: Sun, 04 Mar 2012 12:14:30 +0200 Message-ID: <4F534086.7040607@redhat.com> References: <1328596327-18662-1-git-send-email-michael@ellerman.id.au> <20120207193839.GA20281@amt.cnet> <1328697688.3308.4.camel@concordia> <1328703232.5682.3.camel@concordia> <4F533B3A.40905@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: michael@ellerman.id.au Return-path: Received: from mx1.redhat.com ([209.132.183.28]:48793 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751903Ab2CDKOf (ORCPT ); Sun, 4 Mar 2012 05:14:35 -0500 In-Reply-To: <4F533B3A.40905@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/04/2012 11:51 AM, Avi Kivity wrote: > However kvm_arch_vcpu_init(), which creates the lapic, _is_ called > without either the vcpu->mutex or kvm->lock held. This is irrelevant, the important bit is when it becomes visible. > Patch coming up. I'll add explicit variables for irqchip_in_kernel. They'll be useful for non-x86 as well. -- error compiling committee.c: too many arguments to function